[PATCH] D81939: [deadargelim] Attach dbg info to the insert/extractvalue instructions

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

lgtm from my point of view now.



================
Comment at: llvm/lib/Transforms/IPO/DeadArgumentElimination.cpp:981
             // Insert the value at the old position
-            RetVal = InsertValueInst::Create(RetVal, V, Ri, "oldret", InsertPt);
+            RetVal = IRB.CreateInsertValue(RetVal, V, Ri, "oldret");
           }
----------------
Nice!


================
Comment at: llvm/test/DebugInfo/X86/dbgloc-insert-extract-val-instrs.ll:5
+; RUN: opt < %s -deadargelim -check-debugify -S 2>&1 \
+; RUN:     | FileCheck %s -check-prefix=DEBUG
+
----------------
Why use a custom prefix if there is only one FileCheck invocation?


================
Comment at: llvm/test/DebugInfo/X86/dbgloc-insert-extract-val-instrs.ll:219
+!93 = !DILocation(line: 37, column: 1, scope: !58)
+!94 = !DILocation(line: 38, column: 1, scope: !58)
+
----------------
We might as well delete all the `column: 1` fields, assuming that 0 is the default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81939/new/

https://reviews.llvm.org/D81939