[PATCH] D83477: [Matrix] Tighten LangRef definitions and Verifier checks.

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer marked an inline comment as done.
SjoerdMeijer added inline comments.


================
Comment at: llvm/docs/LangRef.rst:15574
+matrix, using a stride of %Stride between columns. For two consecutive columns
+A and B, %Stride refers to the distance (the number of elements) between the
+start of column A and the start of column B. The result matrix is linearized
----------------
I am actually now also interested in defining  `%Stride` better. Using our new definition:

> For a `R x C` matrix, element `i` of column `j` is at index `j * R + i` in its vector, with indices starting at 0.  

>From the description of %Stride it follows that:

  %Stride = ( (j+1) * R + 0) - (j * R + 0)
  =>
  %Stride = R

So double checking: we can simply the description of %Stride just by saying it is equal to the number of rows, is that correct?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83477/new/

https://reviews.llvm.org/D83477