[PATCH] D69668: Introduce a generic memset to bzero transformation in CodeGen

[Owen Anderson via Phabricator via llvm-commits]

resistor added inline comments.


================
Comment at: llvm/lib/Analysis/TargetLibraryInfo.cpp:55
 
-static bool hasBcmp(const Triple &TT) {
-  // Posix removed support from bcmp() in 2001, but the glibc and several
-  // implementations of the libc still have it.
+static bool hasPosix2001LibCFunctions(const Triple &TT) {
+  // Posix removed support from some libc functions in 2001 (bcmp, bzero), but
----------------
This name reads like it refers to functions that were added in 2001, not to functions that were removed after 2001.


================
Comment at: llvm/test/CodeGen/AArch64/arm64-memset-to-bzero.ll:11
 ; CHECK-LINUX: {{b|bl}} memset
-define void @fct1(i8* nocapture %ptr) minsize {
+define void @fct1(i8* nocapture %ptr) minsize nounwind {
 entry:
----------------
Can you remove these unrelated changes?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69668/new/

https://reviews.llvm.org/D69668