[PATCH] D83264: [ELF] Add -z dead-reloc-in-nonalloc=<section_glob>=<value>

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 09:01:15 PDT 2020


MaskRay added a comment.

In D83264#2140954 <https://reviews.llvm.org/D83264#2140954>, @grimar wrote:

> In D83264#2135482 <https://reviews.llvm.org/D83264#2135482>, @grimar wrote:
>
> > Probably there are other names rather than "dead-reloc-in-nonalloc" which we might want to consider?
> >
> > `-z dead-noalloc-reloc-val`
> >  `-z tombstone-reloc`
> >  `-z resolve-dead-reloc`
>
>
> This remained unanswered.


Dead relocations in SHF_ALLOC sections are errors. `relocateNonAlloc` does not handle them, so `-z tombstone-reloc` and `-z resolve-dead-reloc` are excluded.

For `-z dead-nonalloc-reloc-val` The adjective `nonalloc` appears to describe `reloc`, which is not precise. `nonalloc` describes the section.

I still consider `-z dead-reloc-in-nonalloc` the best.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83264/new/

https://reviews.llvm.org/D83264





More information about the llvm-commits mailing list