[PATCH] D83479: [COFF] Error on unexpected .pdata size

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/COFF/Writer.cpp:1868
+    if ((end - begin) % sizeof(Entry) != 0) {
+      fatal("unexpected .pdata size: " + std::to_string(end - begin) +
+            " is not a multiple of " + std::to_string(sizeof(Entry)));
----------------
Nit: `Twine(end-begin)`

... to avoid a temporary std::string.


================
Comment at: lld/test/COFF/pdata-arm64-bad.yaml:1
+# RUN: yaml2obj < %s > %t.obj
+#
----------------
`yaml2obj %s -o %t.obj`

Drop the `#` on the empty line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83479/new/

https://reviews.llvm.org/D83479