[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:896
+    report_fatal_error("vector info, controlled storage info and extension "
+                       "table of traceback table not yet implemented");
+
----------------
DiggerLin wrote:
> jasonliu wrote:
> > I would hope we could skip the sections we do not want to parse for now gracefully instead of just report_fatal_error and stop parsing all together.
> I think report_fatal_error maybe reasonable here. if we skip the section , how does the user know a object file has  these section or not ?   if report a error , the user will know the llvm-objdump do not support the vector etc section and need to ask to developer the functionality. and I think we also will create a new patch to support vector etc .
It should be possible to create stubs for handling these that print something that makes it clear that the decoding has not been implemented. Using `report_fatal_error` means that a user with an object file containing these are blocked even if they only need to inspect the traceback table for other purposes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585