[PATCH] D83375: [NFC] Separate bitcode reading for FUNC_CODE_INST_CMPXCHG(_OLD)

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:539
   FUNC_CODE_INST_FENCE = 36,       // FENCE: [ordering, synchscope]
-  FUNC_CODE_INST_CMPXCHG_OLD = 37, // CMPXCHG: [ptrty,ptr,cmp,new, align, vol,
-                                   //           ordering, synchscope]
+  FUNC_CODE_INST_CMPXCHG_OLD = 37, // CMPXCHG: [ptrty, ptr, cmp, new, vol,
+                                   //           success_ordering, ssid,
----------------
gchatelet wrote:
> The documentation here was wrong.
> alignment was never stored for `FUNC_CODE_INST_CMPXCHG_OLD` and `failure_ordering` and `weak` were optional.
It used to only have "ordering", and didn't separate success / failure (so it wasn't optional as much as not there).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83375/new/

https://reviews.llvm.org/D83375