[PATCH] D82923: introducing llvm-libtool-darwin

Thu Jul 9 07:56:14 PDT 2020

jhenderson added inline comments.

================
Comment at: llvm/test/tools/llvm-libtool-darwin/help-message.test:5
+# RUN: llvm-libtool-darwin -help | FileCheck --check-prefixes=LIBTOOL-USAGE,CATEG %s --match-full-lines
+# RUN: llvm-libtool-darwin --help | FileCheck --check-prefixes=LIBTOOL-USAGE,CATEG %s --match-full-lines
+# RUN: llvm-libtool-darwin --help-list | \
----------------
sameerarora101 wrote:
> jhenderson wrote:
> > It's quite possible the llvm-size test doesn't have testing for unrelated options. How is it tested in this version now?
> yup, you are right, `llvm-size` doesn't test that unrelated options are not present. For my case, the unrelated option `--safepoint-ir-verifier-print-only:` comes under `General Options:` when I add the support for `-static`. I can add `--implicit-check-not=General` in the second diff D83002 for that?
I think we've done something similar elsewhere. Take a look around, and try seeing if there's a precedent.

I might be inclined for a more verbose --implicit-check-not for "General Options:" for safety (since "General" might appear in somebdoy's path).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923