[PATCH] D83462: [DWARF] Avoid entry_values production for SCE
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 9 07:33:28 PDT 2020
probinson added a comment.
Between this code and DwarfDebug, I'm having a hard time understanding the various controls over emitting entry-values.
- There's an existing tuning check in DwarfDebug, now you're adding the complementary check in TargetOptions. Does this make the DwarfDebug check redundant?
- There are 3 different flags to sort out whether to emit this stuff. SupportsDebugEntryValues is strictly based on the target, I get that. Then there's EnableDebugEntryValues in the TargetOptions, which seems to be tied to a tool-command-line option; and separately there's EmitDwarfDebugEntryValues in DwarfDebug, with its own command-line option. Can we simplify this at all?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83462/new/
https://reviews.llvm.org/D83462
More information about the llvm-commits
mailing list