[PATCH] D83321: [Support] Fix utf16 path's index upper bound

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 06:55:38 PDT 2020


andrewng added a comment.

That test is for `widenPath` and it does cover a similar situation (I know because I wrote it). The code you have changed relates to `directory_iterator_construct` which does not have coverage of the situation where the UTF16 length is less than the UTF8 length, i.e. the issue that you are fixing.

If another reviewer is happy to approve this change without any test coverage, then that's fine with me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83321/new/

https://reviews.llvm.org/D83321





More information about the llvm-commits mailing list