[PATCH] D83483: GlobalISel: Don't use virtual for distinguishing arg handlers

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 06:21:46 PDT 2020


arsenm created this revision.
arsenm added reviewers: aemerson, paquette, aditya_nandakumar, dsanders, rovka, petarj.
Herald added subscribers: kerbowa, atanasyan, hiraditya, arichardson, nhaehnle, wdng, jvesely, sdardis.
Herald added a project: LLVM.

There's no reason to involve the hassle of a virtual method targets
have to override for a simple boolean.

      

Not sure exactly what's going on with Mips, but it seems to define its
own totally separate handler classes.


https://reviews.llvm.org/D83483

Files:
  llvm/include/llvm/CodeGen/GlobalISel/CallLowering.h
  llvm/lib/Target/AArch64/GISel/AArch64CallLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUCallLowering.cpp
  llvm/lib/Target/ARM/ARMCallLowering.cpp
  llvm/lib/Target/Mips/MipsCallLowering.cpp
  llvm/lib/Target/X86/X86CallLowering.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83483.276725.patch
Type: text/x-patch
Size: 24895 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/06eebf65/attachment.bin>


More information about the llvm-commits mailing list