[PATCH] D83469: [LLD][ELF] - Allow relocation sections to appear before their target sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM (with nits), but I'd like a second opinion from somebody with fresher LLD knowledge.



================
Comment at: lld/ELF/InputFiles.cpp:646
+  // 1) handle SHF_LINK_ORDER sections.
+  // 2) create SHT_REL[A} sections. In some cases relocated sections may follow
+  //    the corresponding relocation section. In such a case, the relocation
----------------
Typo? '}' -> ']'


================
Comment at: lld/ELF/InputFiles.cpp:647
+  // 2) create SHT_REL[A} sections. In some cases relocated sections may follow
+  //    the corresponding relocation section. In such a case, the relocation
+  //    section would attempt to reference a target section that has not yet
----------------
Oops, my bad: "a case" -> "cases"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83469/new/

https://reviews.llvm.org/D83469