[PATCH] D83468: [Debuginfo] Fix for PR46653

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

Could you please add a paragraph to the summary that explains why this change is done?



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1987-1989
   // We have an explicit location, different from the previous location.
   // Don't repeat a line-0 record, but otherwise emit the new location.
   // (The new location might be an explicit line 0, which we do emit.)
----------------
AFAICT, this comment is no longer valid.


================
Comment at: llvm/test/DebugInfo/X86/dbg-prolog-end.ll:29
 ;CHECK-LABEL: main:
-;CHECK: .loc 1 0 0 prologue_end
 
 define i32 @main() nounwind ssp !dbg !6 {
----------------
Since this test is called "dbg-prolog-end", perhaps this should still have a CHECK that verifies the position where prologue_end is emitted on?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83468/new/

https://reviews.llvm.org/D83468