[PATCH] D83452: [DWARFYAML] Virtual functions should be overridden in derived class.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D83452#2141125 <https://reviews.llvm.org/D83452#2141125>, @grimar wrote:

> Also, I find the description a bit confusing:
>
> > Virtual functions should be overridden in the derived class
>
> Isn't this change (virtual->override) here a no-op to improve the code style?
>  All these funtions are anyways overriden, with the `override` word or without it.


(I'm working on the assumption that @Higuoxing misunderstood the meaning of virtual and override - see my comment that landed at the same time as yours)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83452/new/

https://reviews.llvm.org/D83452