[PATCH] D83452: [DWARFYAML] Virtual functions should be overridden in derived class.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 01:39:27 PDT 2020


grimar added a comment.

Changing `virtual` -> `override` looks fine to me, but why did you change `private` -> `protected`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83452/new/

https://reviews.llvm.org/D83452





More information about the llvm-commits mailing list