[PATCH] D83387: [llvm-readobj] - Add a generic test for --dyn-relocations and fix an issue.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test:5
+# RUN: yaml2obj --docnum=1 %s -o %t1
+# RUN: llvm-readobj --dyn-relocations %t1 2>&1 | FileCheck %s --check-prefix=LLVM-EMPTY
+# RUN: llvm-readelf --dyn-relocations %t1 2>&1 | FileCheck %s --implicit-check-not={{.}} --allow-empty
----------------
I'd avoid using -EMPTY as a custom prefix name as that might get confused with -EMPTY as the FileCheck check suffix. Perhaps "LLVM-NONE"?


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test:19
+
+## Check how we dump all possbile dynamic relocations sections.
+# RUN: yaml2obj --docnum=2 %s -o %t2.1
----------------
how -> that
relocations -> relocation


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test:104
+        Value: 0x10
+## 0x28 == offset of .rel.dyn section in the segment.
+      - Tag:   DT_RELR
----------------
`.relr.dyn`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83387/new/

https://reviews.llvm.org/D83387