[PATCH] D83372: Fix for memory leak reported by Valgrind

Maksym Wezdecki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 9 00:34:35 PDT 2020


mwezdeck updated this revision to Diff 276641.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83372/new/

https://reviews.llvm.org/D83372

Files:
  llvm/lib/Support/ManagedStatic.cpp


Index: llvm/lib/Support/ManagedStatic.cpp
===================================================================
--- llvm/lib/Support/ManagedStatic.cpp
+++ llvm/lib/Support/ManagedStatic.cpp
@@ -76,8 +76,12 @@
 
 /// llvm_shutdown - Deallocate and destroy all ManagedStatic variables.
 void llvm::llvm_shutdown() {
-  std::lock_guard<std::recursive_mutex> Lock(*getManagedStaticMutex());
+  std::recursive_mutex *mtx = getManagedStaticMutex();
 
+  mtx->lock();
   while (StaticList)
     StaticList->destroy();
+  mtx->unlock();
+
+  delete mtx;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83372.276641.patch
Type: text/x-patch
Size: 547 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200709/a6102b8f/attachment.bin>


More information about the llvm-commits mailing list