[PATCH] D83002: [llvm-libtool-darwin] Add support for -static option

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with one optional suggestion.



================
Comment at: llvm/test/tools/llvm-libtool-darwin/create-static-lib.test:51
+## The warning is not yet implemented for llvm-libtool-darwin.
+# RUN: llvm-libtool-darwin -static -o %t.lib %t-input1.o %t-input2.o %t-input1.o
+# RUN: llvm-ar t %t.lib | \
----------------
It might be worth adding a `2&>1` and check the output is empty here, to flag up if a warning starts getting emitted. That way, it points to where to add testing for the warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83002/new/

https://reviews.llvm.org/D83002