[PATCH] D83456: [NFC][AArch64] Refactor getArgumentPopSize
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jul 9 00:22:30 PDT 2020
plotfi accepted this revision.
plotfi added subscribers: thegameg, aemerson.
plotfi added a comment.
This revision is now accepted and ready to land.
LGTM, but I'd like @thegameg or @aemerson to take a look as well. Thanks!
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:190
+ RetOpcode == AArch64::TCRETURNriBTI;
+ }
+ AArch64FunctionInfo *AFI = MF.getInfo<AArch64FunctionInfo>();
----------------
I think this could be a nicer refactoring, for a future NFC, but ignore this for now (in interest of straight forward NFC reviewing):
```
const bool IsTailCallReturn = (MBB.end() != MBBI) &&
[](unsigned RetOpcode) {
return (RetOpcode == AArch64::TCRETURNdi ||
RetOpcode == AArch64::TCRETURNri ||
RetOpcode == AArch64::TCRETURNriBTI);
} (MBBI->getOpcode());
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83456/new/
https://reviews.llvm.org/D83456
More information about the llvm-commits
mailing list