[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:849
+static SmallString<32> parseParaType(uint32_t Value, unsigned ParaNum) {
+  SmallString<32> ParaType;
+  for (unsigned I = 0; I < ParaNum; ++I) {
----------------
hubert.reinterpretcast wrote:
> jasonliu wrote:
> > Why always 32? As I mentioned in the other comment, ParaNum have implication for how large your SmallString could be. 
> The template argument needs to be a compile time constant.
Yes, sorry I missed that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81585/new/

https://reviews.llvm.org/D81585