[PATCH] D82923: introducing llvm-libtool-darwin

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 20:09:10 PDT 2020


smeenai added inline comments.


================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:18
+
+static cl::opt<std::string> OutputFile("output",
+                                       cl::desc("Specify output filename"),
----------------
sameerarora101 wrote:
> smeenai wrote:
> > As far as I can see, cctools libtool doesn't support the `-output` spelling, only `-o`. Is there any reason for us to support it?
> Yup, that is true. I was just looking at other llvm tools and they have `-output` in addition to `-o`. So I thought of adding both. I can remove `-output` if you guys prefer that?
I'd prefer to remove it, to mimic cctools libtool's interface as closely as possible.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923





More information about the llvm-commits mailing list