[PATCH] D82233: [lit] Add --show-xxx command line options

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 16:45:18 PDT 2020


jdenny accepted this revision.
jdenny added a comment.
This revision is now accepted and ready to land.

The last update lost a drive-by fix for `MAX_FAILURES`.  I didn't check to see if that was fixed elsewhere.

Other than the comment suggestion I just added, LGTM.



================
Comment at: llvm/utils/lit/lit/cl_arguments.py:71
+                     if not c.isFailure]
+    for code in success_codes:
+        format_group.add_argument(
----------------
I'd appreciate a comment here to clarify that user-defined result codes are not supported by `--show-*`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82233/new/

https://reviews.llvm.org/D82233





More information about the llvm-commits mailing list