[PATCH] D83037: [llvm-readobj] - Fix a crash scenario in GNUStyle<ELFT>::printHashSymbols().

Fāng-ruì Sòng via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 16:34:01 PDT 2020


Perhaps information wasn't propagated in time. For the two patches I
landed today, the emails are good:

"""
This revision was automatically updated to reflect the committed changes.
Closed by commit rG169ec2d6b006: [ELF] Rename canRelax to toExecRelax.
NFC (authored by MaskRay).
"""
"""
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe89c075f3251: [test] Run llvm/test/**/*.yaml &
don't run llvm/test/**/*.cxx (not exist) (authored by MaskRay).
"""

On Tue, Jul 7, 2020 at 2:47 AM James Henderson
<jh7370.2008 at my.bristol.ac.uk> wrote:
>
> Hi @Mehdi/MaskRay,
>
> Looks like something else odd is going on with Phabricator - I accepted this patch, but when it landed, I got this email saying it landed in a "Needs Review" state (see below). Probably there's something wrong with Phabricator again?
>
> James
>
>
> On Tue, 7 Jul 2020 at 10:41, George Rimar via Phabricator <reviews at reviews.llvm.org> wrote:
>>
>> This revision was not accepted when it landed; it landed in state "Needs Review".
>> This revision was automatically updated to reflect the committed changes.
>> Closed by commit rGd5cbf7ba3252: [llvm-readobj] - Fix a crash scenario in GNUStyle<ELFT>::printHashSymbols(). (authored by grimar).
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D83037/new/
>>
>> https://reviews.llvm.org/D83037
>>
>> Files:
>>   llvm/test/tools/llvm-readobj/ELF/hash-symbols.test
>>   llvm/tools/llvm-readobj/ELFDumper.cpp
>>


-- 
宋方睿


More information about the llvm-commits mailing list