[PATCH] D83440: [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 15:46:17 PDT 2020


craig.topper marked an inline comment as done.
craig.topper added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:4124
+  // select ?, undef, X -> X
+  if (isa<UndefValue>(TrueVal) && isGuaranteedNotToBeUndefOrPoison(FalseVal))
+    return FalseVal;
----------------
Should I be passing CxtI and DT here? I based this off the code in SimplifyInsertElementInst, but maybe i should have based it off of SimplifyFreezeInst?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83440/new/

https://reviews.llvm.org/D83440





More information about the llvm-commits mailing list