[PATCH] D83351: [llvm-reduce] Reducing attributes

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 15:06:05 PDT 2020


lebedev.ri updated this revision to Diff 276573.
lebedev.ri added a comment.

In D83351#2140238 <https://reviews.llvm.org/D83351#2140238>, @nickdesaulniers wrote:

> In D83351#2140189 <https://reviews.llvm.org/D83351#2140189>, @lebedev.ri wrote:
>
> > In D83351#2140177 <https://reviews.llvm.org/D83351#2140177>, @nickdesaulniers wrote:
> >
> > > In D83351#2140113 <https://reviews.llvm.org/D83351#2140113>, @lebedev.ri wrote:
> > >
> > > > I will split this up into several commits when landing.
> > >
> > >
> > > What's the plan?
> >
> >
> > langref(?), test cleanup, for_each cleanup, rest of the patch
>
>
> SGTM, if you want to split those off in child revisions/phab reviews I'd be happy to review/approve test cleanup, for_each, and the rebased patch for this feature.


Since that wasn't paired with an accept, i can only surmise that it wasn’t an offer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83351/new/

https://reviews.llvm.org/D83351

Files:
  llvm/test/Reduce/remove-attributes-from-intrinsic-like-functions.ll
  llvm/test/Reduce/remove-attributes-from-intrinsics.ll
  llvm/test/Reduce/remove-call-site-attributes.ll
  llvm/test/Reduce/remove-function-attributes.ll
  llvm/test/Reduce/remove-global-variable-attributes.ll
  llvm/tools/llvm-reduce/CMakeLists.txt
  llvm/tools/llvm-reduce/DeltaManager.h
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp
  llvm/tools/llvm-reduce/deltas/ReduceAttributes.h
  llvm/utils/gn/secondary/llvm/tools/llvm-reduce/BUILD.gn

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83351.276573.patch
Type: text/x-patch
Size: 16837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/0ae5391a/attachment-0001.bin>


More information about the llvm-commits mailing list