[PATCH] D83351: [llvm-reduce] Reducing attributes
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 8 14:47:27 PDT 2020
lebedev.ri added inline comments.
================
Comment at: llvm/tools/llvm-reduce/deltas/ReduceAttributes.cpp:74-76
+ if (F.getIntrinsicID() != Intrinsic::not_intrinsic)
+ return; // We can neither add nor remove attributes from intrinsics.
+ visitAttributeList(F.getAttributes(), FunctionsToRefine[&F]);
----------------
nickdesaulniers wrote:
> ```
> // We can neither add nor remove attributes from intrinsics.
> if (F.getIntrinsicID() == Intrinsic::not_intrinsic)
> visitAttributeList(F.getAttributes(), FunctionsToRefine[&F]);
> ```
We can do that, with no line count diff and doesn't the comment loos context - right now it's accurately on the early-return?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83351/new/
https://reviews.llvm.org/D83351
More information about the llvm-commits
mailing list