[PATCH] D83255: [PowerPC] Split s34imm into two types

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:399
       def PLI8 : MLS_DForm_SI34_RT5<14, (outs g8rc:$RT),
-                                    (ins s34imm:$SI),
+                                    (ins s34imm_pcrel:$SI),
                                     "pli $RT, $SI", IIC_IntSimple, []>;
----------------
nemanjai wrote:
> It seems very odd to me that we would use the `_pcrel` version here. There should be no way to do anything PC-relative with this instruction since it will necessarily set the PC-Rel bit to zero. The immediate should always be a real immediate (never any fixup).
> 
> So although it doesn't matter, we should probably not use the `_pcrel` version because it will be confusing. I was certainly confused and wrote about 3 versions of this comment :)
You are correct.
For some reason I added this here thinking that `MLS_DForm_SI34_RT5` was a multi-class just like the one above it... Anyway, I'll fix it.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83255/new/

https://reviews.llvm.org/D83255