[PATCH] D83351: [llvm-reduce] Reducing attributes
Nick Desaulniers via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 8 12:41:11 PDT 2020
nickdesaulniers requested changes to this revision.
nickdesaulniers added a comment.
This revision now requires changes to proceed.
In D83351#2139818 <https://reviews.llvm.org/D83351#2139818>, @lebedev.ri wrote:
> so i'm still waiting on the link/patch.
Treat your fellow contributors with more respect, please. I know style disagreements aren't exciting, but we're all on the same team. I much prefer LLVM's community to the Linux kernel's for a reason, and I think it's worthwhile to speak up in defense of it, lest it decay. I'm not the best at maintaining this myself, so if you see me break my own standards, please feel empowered to call me out.
Another benefit of range for here is we don't need the braces, so these can be 2 lines instead of 3. Please change them to be consistent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83351/new/
https://reviews.llvm.org/D83351
More information about the llvm-commits
mailing list