[PATCH] D82820: [InstCombine] Fix mismatched attribute lists for combined calls

[Gui Andrade via Phabricator via llvm-commits]

guiand added a comment.

@eugenis and I discussed the possibility that removing attributes like this could cause problems if, for some reason, the ABI of a libcall changes as a result. The test I added actually demonstrates this: the `inreg` attribute is removed from the calls, which could change the behavior.

But this is only a concern if there's some reason to specify ABI-changing attributes to libcalls in the callsite like this, and not have LLVM put them in the declaration. Which I'm not sure there is. What are peoples' thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82820/new/

https://reviews.llvm.org/D82820