[PATCH] D83331: [PGO][PGSO] Add profile guided size optimization to X86ISelDAGToDAG.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 12:23:16 PDT 2020


yamauchi marked an inline comment as done.
yamauchi added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelDAGToDAG.cpp:165
     /// performance.
     bool OptForSize;
 
----------------
craig.topper wrote:
> ARe more changes needed to get rid of this member?
The only remaining use is for the "OptForMinSize implies OptForSize" assert in runOnMachineFunction.

I turned into a local variable there to keep the assert.

We could also remove it along with the assert if it'd be better that way.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83331/new/

https://reviews.llvm.org/D83331





More information about the llvm-commits mailing list