[PATCH] D83335: [ScheduleDAGRRList] Use std::*_heap() to keep candidate queue a heap.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 8 12:16:46 PDT 2020
efriedma added a comment.
> After looking at the code for the source order comperator, it looks like the score could change after units are scheduled as well in some edge cases.
So AssertisHeap might fail? I'm not really comfortable with that...
> We might even go further and limit the source order comperator to just the IR ordering and the queue IDs, because the real scheduling should happen in the machine scheduler.
Make this a separate patch, in case it has some unexpected side-effect, but sure, that makes sense.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83335/new/
https://reviews.llvm.org/D83335
More information about the llvm-commits
mailing list