[PATCH] D83409: [opt] Remove obsolete --quiet option

[Hans Wennborg via Phabricator via llvm-commits]

hans accepted this revision.
hans added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Support/SystemUtils.cpp:20
   if (stream_to_check.is_displayed()) {
-    if (print_warning) {
       errs() << "WARNING: You're attempting to print out a bitcode file.\n"
                 "This is inadvisable as it may cause display problems. If\n"
----------------
nit: the indentation needs readjusting


================
Comment at: llvm/tools/opt/PassPrinters.cpp:75
   bool runOnSCC(CallGraphSCC &SCC) override {
-    if (!QuietPass)
       Out << "Printing analysis '" << PassToPrint->getPassName() << "':\n";
 
----------------
nit: indent


================
Comment at: llvm/tools/opt/PassPrinters.cpp:110
   bool runOnModule(Module &M) override {
-    if (!QuietPass)
       Out << "Printing analysis '" << PassToPrint->getPassName() << "':\n";
 
----------------
indent


================
Comment at: llvm/tools/opt/PassPrinters.cpp:140
   bool runOnLoop(Loop *L, LPPassManager &LPM) override {
-    if (!QuietPass)
       Out << "Printing analysis '" << PassToPrint->getPassName() << "':\n";
 
----------------
indent


================
Comment at: llvm/tools/opt/PassPrinters.cpp:171
   bool runOnRegion(Region *R, RGPassManager &RGM) override {
-    if (!QuietPass) {
       Out << "Printing analysis '" << PassToPrint->getPassName() << "' for "
           << "region: '" << R->getNameStr() << "' in function '"
----------------
indent


================
Comment at: llvm/tools/opt/opt.cpp:208
-static cl::opt<bool>
-Quiet("q", cl::desc("Obsolete option"), cl::Hidden);
-
----------------
Might be worth mentioning the option was "neutered" in r13844


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83409/new/

https://reviews.llvm.org/D83409