[PATCH] D83413: Tighten description of ISD::BUILD_VECTOR

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally created this revision.
cameron.mcinally added reviewers: craig.topper, kparzysz, lebedev.ri.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

VerifySDNode(...) in SelectionDAG.cpp shows that the operands of a BUILD_VECTOR must all be the same type. This patch cleans up the comment in ISDOpcodes.h to make that more obvious.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83413

Files:
  llvm/include/llvm/CodeGen/ISDOpcodes.h


Index: llvm/include/llvm/CodeGen/ISDOpcodes.h
===================================================================
--- llvm/include/llvm/CodeGen/ISDOpcodes.h
+++ llvm/include/llvm/CodeGen/ISDOpcodes.h
@@ -450,9 +450,9 @@
   /// BUILD_VECTOR(ELT0, ELT1, ELT2, ELT3,...) - Return a fixed-width vector
   /// with the specified, possibly variable, elements.  The number of elements
   /// is required to be a power of two. The types of the operands must all be
-  /// the same and must match the vector element type, except that integer types
-  /// are allowed to be larger than the element type, in which case the operands
-  /// are implicitly truncated.
+  /// the same. The types of the operands must match the vector element type,
+  /// except that integer types are allowed to be larger than the element type,
+  /// in which case the operands are implicitly truncated.
   BUILD_VECTOR,
 
   /// INSERT_VECTOR_ELT(VECTOR, VAL, IDX) - Returns VECTOR with the element


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83413.276452.patch
Type: text/x-patch
Size: 970 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/10367220/attachment.bin>