[PATCH] D83379: [Coroutines] Refactor sinkLifetimeStartMarkers

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 09:17:00 PDT 2020


lxfind added a comment.

Thank you for looking into the fix!



================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:1578
+      auto isUsedByLifetimeStart = [&](Instruction *I) {
+        if (isa<BitCastInst>(I) && I->hasOneUse())
+          if (auto *IT = dyn_cast<IntrinsicInst>(I->user_back()))
----------------
If I is a BitCastInst, wouldn't it be used by both lifetime.start and lifetime.end intrinsics, and hence has more than one user?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83379/new/

https://reviews.llvm.org/D83379





More information about the llvm-commits mailing list