[PATCH] D83002: [llvm-libtool-darwin] Add support for -static option

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 11 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/create-static-lib.test:32
+# FORMAT-NEXT: [[PREFIX]]-input2.o
+# FORMAT_NOT:  {{.}}
+
----------------
smeenai wrote:
> You have an underscore instead of a dash :)
> 
> Is the purpose to ensure that there's no other members? I assume a -EMPTY would work for that. We should also check for the "Archive : " header, to ensure there's no members before the table of contents member.
Thanks for catching the underscore.

I added a check for "Archive : " header now. However, using `FORMAT-EMPTY` would just check that the next line (after 2nd member) has nothing on it. What I thought we wanted to check was that there is nothing at all after the second member. For eg,

```
Archive : ...
... __.SYMDEF
...<prefix>-input1.o
...<prefix>-input2.o

something here
```
would pass with `FORMAT-EMPTY` just below the check for second member, right? But we want it to fail.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/hide-unrelated-options.test:1
+## This test checks that unrelated options are hidden in help text.
+
----------------
smeenai wrote:
> This seems unrelated to this diff; perhaps it should be in the previous one?
Yup, thanks. Moved it to the previous diff D82923


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83002/new/

https://reviews.llvm.org/D83002