[PATCH] D81267: [LV] Enable the LoopVectorizer to create pointer inductions

[Dave Green via Phabricator via llvm-commits]

dmgreen added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1033

----------------
Latch might be a better name here.


================
Comment at: llvm/test/Transforms/LoopVectorize/pointer-induction.ll:4
+target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
----------------
I think if you use x86 as a target (and needs it for the costing), the test needs to go into test/Transforms/LoopVectorize/X86 in case the target is not compiled in.


================
Comment at: llvm/test/Transforms/LoopVectorize/pointer-induction.ll:7
+; Function Attrs: nofree norecurse nounwind
+define void @a(i8* readnone %b) local_unnamed_addr #0 {
+; CHECK-LABEL: @a(
----------------
Also some of this might be able to be cleaned up, like the local_unnamed_addr, the metadata and all/most(?) of the attributes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81267/new/

https://reviews.llvm.org/D81267