[PATCH] D83387: [llvm-readobj] - Add a generic test for --dyn-relocations and fix an issue.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 05:10:40 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay.
Herald added subscribers: rupprecht, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

We have an issue currently: --dyn-relocations always prints the following
relocation header when dumping `DynPLTRelRegion`:

"Offset  Info  Type Symbol's Value  Symbol's Name + Addend"

I.e. even for an empty object, --dyn-relocations still prints this.
It is a easy to fix bug, but we have no dedicated test case for this option.
(we have a dynamic-reloc-no-section-headers.test, which has a slightly different purpose).

This patch adds a test and fixes the behavior.


https://reviews.llvm.org/D83387

Files:
  llvm/test/tools/llvm-readobj/ELF/dynamic-reloc.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83387.276384.patch
Type: text/x-patch
Size: 6517 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/be7505f2/attachment.bin>


More information about the llvm-commits mailing list