[PATCH] D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation
Stefan Pintilie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jul 8 04:29:30 PDT 2020
stefanp added inline comments.
================
Comment at: lld/ELF/Thunks.cpp:982
+ if ((s.stOther >> 5) == 1 && type == R_PPC64_REL24)
+ return make<PPC64R2SaveStub>(s);
----------------
MaskRay wrote:
> This needs a comment.
I've added a comment.
Adding the comment forced me to re-assess the condition statement so I've also changed the condition to be just:
```
if ((s.stOther >> 5) == 1)
```
There was no reason to exclude R_PPC64_REL14 from this condition.
I have also added a test for R_PPC64_REL14.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D82950/new/
https://reviews.llvm.org/D82950
More information about the llvm-commits
mailing list