[PATCH] D77422: [llvm-exegesis] Add benchmark mode that uses LBR for more precise measurements.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 8 01:07:49 PDT 2020


courbet added inline comments.


================
Comment at: llvm/tools/llvm-exegesis/lib/X86/X86Counter.cpp:178
+  const void *To = nullptr;
+  if (!FunctionBytes.empty()) {
+    From = reinterpret_cast<const void *>(FunctionBytes.data());
----------------
Let's return an error when `FunctionBytes.empty()`. Right now this will assert later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77422/new/

https://reviews.llvm.org/D77422





More information about the llvm-commits mailing list