[PATCH] D83366: [MC] Simplify the logic of applying fixup for fragments, NFCI
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 22:02:15 PDT 2020
skan added a comment.
In D83366#2138183 <https://reviews.llvm.org/D83366#2138183>, @MaskRay wrote:
> Note that the number of lines actually increases... so I am not sure this is "simplification"
The increased line number comes from `}` and `break`, the logic is simplified and corrected since we do not need to check `isa<MCEncodedFragment>` here. We extract the code for "MCAlignFragment" out to make it clear that it doesn't have fixup. If you care
about the increased line number here, I can remove the unnecessary "{}" here or use `if` statement.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D83366/new/
https://reviews.llvm.org/D83366
More information about the llvm-commits
mailing list