[PATCH] D83368: [NewPM][opt] Share -disable-loop-unrolling between pass managers

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks created this revision.
aeubanks added a reviewer: echristo.
Herald added subscribers: llvm-commits, zzheng.
Herald added a project: LLVM.

There's no reason to introduce a new option for the NPM.
The various PGO options are shared in this manner.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83368

Files:
  llvm/test/Transforms/LoopUnroll/FullUnroll.ll
  llvm/tools/opt/NewPMDriver.cpp
  llvm/tools/opt/opt.cpp


Index: llvm/tools/opt/opt.cpp
===================================================================
--- llvm/tools/opt/opt.cpp
+++ llvm/tools/opt/opt.cpp
@@ -183,10 +183,9 @@
 static cl::opt<std::string>
 TargetTriple("mtriple", cl::desc("Override target triple for module"));
 
-static cl::opt<bool>
-DisableLoopUnrolling("disable-loop-unrolling",
-                     cl::desc("Disable loop unrolling in all relevant passes"),
-                     cl::init(false));
+cl::opt<bool> DisableLoopUnrolling(
+    "disable-loop-unrolling",
+    cl::desc("Disable loop unrolling in all relevant passes"), cl::init(false));
 
 static cl::opt<bool> EmitSummaryIndex("module-summary",
                                       cl::desc("Emit module summary index"),
Index: llvm/tools/opt/NewPMDriver.cpp
===================================================================
--- llvm/tools/opt/NewPMDriver.cpp
+++ llvm/tools/opt/NewPMDriver.cpp
@@ -102,9 +102,7 @@
     cl::Hidden);
 
 // Individual pipeline tuning options.
-static cl::opt<bool> DisableLoopUnrolling(
-    "new-pm-disable-loop-unrolling",
-    cl::desc("Disable loop unrolling in all relevant passes"), cl::init(false));
+extern cl::opt<bool> DisableLoopUnrolling;
 
 extern cl::opt<PGOKind> PGOKindFlag;
 extern cl::opt<std::string> ProfileFile;
Index: llvm/test/Transforms/LoopUnroll/FullUnroll.ll
===================================================================
--- llvm/test/Transforms/LoopUnroll/FullUnroll.ll
+++ llvm/test/Transforms/LoopUnroll/FullUnroll.ll
@@ -1,4 +1,4 @@
-; RUN: opt -passes='default<O1>' -disable-verify --mtriple x86_64-pc-linux-gnu -new-pm-disable-loop-unrolling=true \
+; RUN: opt -passes='default<O1>' -disable-verify --mtriple x86_64-pc-linux-gnu -disable-loop-unrolling=true \
 ; RUN: -S -o - %s | FileCheck %s
 
 ; This checks that the loop full unroller will fire in the new pass manager


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83368.276309.patch
Type: text/x-patch
Size: 1880 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200708/bdb13078/attachment.bin>