[llvm] e885f33 - Revert "[X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70f3ed2a91e0a48c6448c517c3ba34c2846"
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 19:57:31 PDT 2020
Author: Nico Weber
Date: 2020-07-07T22:56:08-04:00
New Revision: e885f336fd78e35ccb8e967e0664b356de333963
URL: https://github.com/llvm/llvm-project/commit/e885f336fd78e35ccb8e967e0664b356de333963
DIFF: https://github.com/llvm/llvm-project/commit/e885f336fd78e35ccb8e967e0664b356de333963.diff
LOG: Revert "[X86] Add back the assert in getImpliedFeatures that I removed in ef4cc70f3ed2a91e0a48c6448c517c3ba34c2846"
This reverts commit 91f70675cc6e5c872e0059c11d797b8726eeac67.
It seems to break most (all?) hwasan tests.
Added:
Modified:
llvm/include/llvm/Support/X86TargetParser.def
llvm/lib/Support/X86TargetParser.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/Support/X86TargetParser.def b/llvm/include/llvm/Support/X86TargetParser.def
index ed41295166b3..4b96c66b0e29 100644
--- a/llvm/include/llvm/Support/X86TargetParser.def
+++ b/llvm/include/llvm/Support/X86TargetParser.def
@@ -226,6 +226,5 @@ X86_FEATURE (RETPOLINE_INDIRECT_BRANCHES, "retpoline-indirect-branches")
X86_FEATURE (RETPOLINE_INDIRECT_CALLS, "retpoline-indirect-calls")
X86_FEATURE (LVI_CFI, "lvi-cfi")
X86_FEATURE (LVI_LOAD_HARDENING, "lvi-load-hardening")
-X86_FEATURE (SESES, "seses")
#undef X86_FEATURE_COMPAT
#undef X86_FEATURE
diff --git a/llvm/lib/Support/X86TargetParser.cpp b/llvm/lib/Support/X86TargetParser.cpp
index cbb7f6186d0d..7e87d65a7c56 100644
--- a/llvm/lib/Support/X86TargetParser.cpp
+++ b/llvm/lib/Support/X86TargetParser.cpp
@@ -446,7 +446,6 @@ static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_BRANCHES = {};
static constexpr FeatureBitset ImpliedFeaturesRETPOLINE_INDIRECT_CALLS = {};
static constexpr FeatureBitset ImpliedFeaturesLVI_CFI = {};
static constexpr FeatureBitset ImpliedFeaturesLVI_LOAD_HARDENING = {};
-static constexpr FeatureBitset ImpliedFeaturesSESES = {};
// XSAVE features are dependent on basic XSAVE.
static constexpr FeatureBitset ImpliedFeaturesXSAVEC = FeatureXSAVE;
@@ -574,7 +573,6 @@ void llvm::X86::getImpliedFeatures(
if (I == std::end(FeatureInfos)) {
// FIXME: This shouldn't happen, but may not have all features in the table
// yet.
- assert(false && "Feature not found in table!");
return;
}
More information about the llvm-commits
mailing list