[PATCH] D78861: [Attributor] [WIP] Track AA dependency using dependency graph
Johannes Doerfert via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 17:43:42 PDT 2020
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
Some minor things (below and from the last comment). LGTM otherwise. Thx :)
================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:2072
+ static bool classof(const AADepGraphNode *DGN) { return true; }
+
----------------
Add a comment here and explain (especially) why we only return true.
================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2175
+ for (AbstractAttribute *AA : AAs)
+ AA->printWithDeps(errs());
+}
----------------
Nit: use `outs` for `print`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78861/new/
https://reviews.llvm.org/D78861
More information about the llvm-commits
mailing list