[PATCH] D81901: GlobalISel: Implement bitcast action for G_EXTRACT_VECTOR_ELEMENT

[Aditya Nandakumar via Phabricator via llvm-commits]

aditya_nandakumar added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:2248
+  LLT SrcEltTy = SrcVecTy.getElementType();
+  if (DstTy != SrcEltTy)   // XXX - Is this valid mir?
+    return UnableToLegalize;
----------------
aemerson wrote:
> I don't think so.
> 
> @aditya_nandakumar G_EXTRACT_VECTOR_ELT doesn't extend/truncate the element right?
Nope. Plan was to add a truncating version of it which I didn't get around to doing. Thanks for the reminder though - I'll try to get to it soon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81901/new/

https://reviews.llvm.org/D81901