[PATCH] D82950: [PowerPC] Support PCRelative Callees for R_PPC64_REL24 Relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:843
+  if (!isInt<26>(offset))
+    fatal("R2 save stub branch offset is too large.");
+  write32(buf + 0, 0xf8410018);                         // std  r2,24(r1)
----------------
Drop trailing period. http://llvm.org/docs/CodingStandards.html#error-and-warning-messages

`"R2 save stub branch offset is too large: " + Twine(offset)`


================
Comment at: lld/test/ELF/ppc64-error-toc-local-call.s:15
+	.localentry	callee, 1
+	addi 3, 3, 5                                       # 0x0
+	extsw 3, 3
----------------
Delete   `addi 3, 3, 5` and extsw. They are irrelevant.


================
Comment at: lld/test/ELF/ppc64-error-toc-local-call.s:25
+	.localentry	caller, .Lfunc_lep1-.Lfunc_gep1
+	mr	30, 3
+	bl callee                                          # 0x18
----------------
Delete irrelevant mr and add


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82950/new/

https://reviews.llvm.org/D82950