[PATCH] D75306: [ms] [llvm-ml] Add initial MASM STRUCT/UNION support

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/tools/llvm-ml/struct_errors.test:10
+t1 int_test <<1,2,3>>
+// CHECK: error: Initializer too long for field
+
----------------
This diag could probably add "expected at most %d elements, got %d" at the end


================
Comment at: llvm/test/tools/llvm-ml/struct_errors.test:48
+t9 STRUCT 3
+// CHECK: error: unsupported alignment value
+t9 ENDS
----------------
this could maybe say "alignment must be power of two, got %d" or similar (I realize it's an existing diag)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75306/new/

https://reviews.llvm.org/D75306