[PATCH] D83255: [PowerPC] Split s34imm into two types

[Kamau Bridgeman via Phabricator via llvm-commits]

kamaub accepted this revision as: kamaub.
kamaub added a comment.
This revision is now accepted and ready to land.

This is LGTM, one suggestion on the clang-format change that can be done pre-commit.



================
Comment at: llvm/lib/Target/PowerPC/MCTargetDesc/PPCAsmBackend.cpp:97
+        // name                    offset  bits  flags
+        {"fixup_ppc_br24", 6, 24, MCFixupKindInfo::FKF_IsPCRel},
+        {"fixup_ppc_br24_notoc", 6, 24, MCFixupKindInfo::FKF_IsPCRel},
----------------
I think it might be a good idea to ignore the clang-format suggestions in this case since the previous way is alot more readable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83255/new/

https://reviews.llvm.org/D83255