[PATCH] D82820: [InstCombine] Fix mismatched attribute lists for combined calls

Gui Andrade via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 09:48:16 PDT 2020


guiand added a comment.

I was discussing with @eugenis about this and he suggested that it's reasonable not to copy any call-inst attributes when simplifying LibCalls. Specifically because you run into these messy questions of how reasonable it is to blindly apply attributes as a caller. Since LibCalls have their own inherent attribute lists which get applied upon creating a `Function` instance for them, it seems like we shouldn't impose any further attributes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82820/new/

https://reviews.llvm.org/D82820





More information about the llvm-commits mailing list