[PATCH] D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 7 09:33:18 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:348
+
+ static constexpr uint32_t FixedParaTypeBit = 0x8000'0000;
+ static constexpr uint32_t FloatPointParaTypeBit = 0x4000'0000;
----------------
jasonliu wrote:
> TODO: add a comment to say this is for other purpose?
Sorry... TODO was for my reviewing purpose.
What I wanted to say is that we might want to add a comment here to separate FixedParaTypeBit and FloatPointParaTypeBit from above `Byte [num]`. Just a blank line is not enough.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81585/new/
https://reviews.llvm.org/D81585
More information about the llvm-commits
mailing list