[PATCH] D83287: [NFCI][llvm-reduce] Cleanup Delta passes to use Oracle abstraction

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 7 09:25:42 PDT 2020


nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.

Thanks, this makes the delta passes much more readable.  It even looks like it might be simpler to avoid some of the local `std::vector`'s now, folding some of the loops.



================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.h:53
+/// actually understand what is going on.
+struct Oracle {
+  /// Out of all the features that we promised to be,
----------------
class


================
Comment at: llvm/tools/llvm-reduce/deltas/Delta.h:63
+public:
+  Oracle(ArrayRef<Chunk> ChunksToKeep_) : ChunksToKeep(ChunksToKeep_) {}
+
----------------
explicit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83287/new/

https://reviews.llvm.org/D83287





More information about the llvm-commits mailing list